feat: allow template specialization #598
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
MaxSagebaum
reviewed
Aug 18, 2023
Contributor
MaxSagebaum
left a comment
MaxSagebaum
left a comment
There was a problem hiding this comment.
LGTM, but I have doubts about the choice of the type keyword.
I had problems with the newest version of gcc.
JohelEGP
force-pushed
the
template_specialization
branch
from
0f4436c to
eb04fb1
Compare
JohelEGP
changed the title
JohelEGP
force-pushed
the
template_specialization
branch
from
eb04fb1 to
3aa3929
Compare
JohelEGP
force-pushed
the
template_specialization
branch
from
3aa3929 to
16174b3
Compare
JohelEGP
force-pushed
the
template_specialization
branch
from
16174b3 to
dc850fa
Compare
JohelEGP
force-pushed
the
template_specialization
branch
from
7dd5d76 to
955a8ec
Compare
JohelEGP
force-pushed
the
template_specialization
branch
from
e01a933 to
d7cc82a
Compare
JohelEGP
referenced
this pull request
Dec 13, 2023
JohelEGP
force-pushed
the
template_specialization
branch
from
3d0c7a2 to
3bfd904
Compare
JohelEGP
force-pushed
the
template_specialization
branch
from
3bfd904 to
12ad062
Compare
The syntax is `specialize<specialization_arguments>`
after the optional template parameter list.
Some examples from the tests:
```Cpp2
std: namespace = {
common_type: @struct @print specialize<outer, outer> type = {
type: type == outer;
}
}
v: <T> const i32 = 1;
v: <> specialize<void> const i32 = 2;
v: specialize<i64> const i32 = 3;
v: <T> specialize<* T> std::optional<int> == 6;
```
JohelEGP
force-pushed
the
template_specialization
branch
from
b8dc740 to
32d1ebd
Compare
Owner
|
Hi! Sorry it took me so long to get to this one... but this looks like it might still be current. Is this up to date, and would you like me to review it? |
hsutter
added
the
question - further information requested
Contributor
Author
|
Yes, and yes, please do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #467.
Partially addresses #387 (#387 (comment)).