This repository has been archived by the owner on Nov 18, 2022. It is now read-only.
HttpTracker: Http Service remove was not handled properly #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsure it is called
…for HttpService instances as well remove explict unget call for resource tracker because the unget from ServiceContainer is applied here as well
|
@stefanseifert can you rework the pull request in a single commit that is mergable? Thanks in advance. |
|
i've merged the pull request with your current master, it merged fine without conflicts. |
|
Perfect. Thanks! |
|
The changes of this pull request were also included in #93 and are merged into master now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while debugging i finally spotted the source of the problem for #65.
the main reason was a very subtle bug in HttpTracker with a wrong signature resulting that the method was never called. and unget service was not called properly for http services.