Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use different Windows NUL device for GHC 8.6.5 #7 #8

Merged
merged 2 commits into from
Jul 21, 2019
Merged

Use different Windows NUL device for GHC 8.6.5 #7 #8

merged 2 commits into from
Jul 21, 2019

Conversation

snoyberg
Copy link
Collaborator

No description provided.

@sol
Copy link
Member

sol commented Jul 20, 2019

@snoyberg hey, thanks for opening this PR! I don't use silently myself much anymore and hspec hasn't relied on it for a couple of years now.

I gave you repo permissions and Hackage upload rights. If you are comfortable with this change then please feel free to go ahead and push a release ;).

@snoyberg
Copy link
Collaborator Author

Thanks! I don't think I have write access though, since I'm unable to merge this PR.

@snoyberg
Copy link
Collaborator Author

Upload to Hackage done, thanks for adding the perms.

@snoyberg snoyberg merged commit 56b43aa into hspec:master Jul 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants