feat: support Spark-compatible abs math function part 2 - ANSI mode #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsiang-c
changed the title
github-merge-queue bot
pushed a commit
to apache/datafusion
that referenced
this pull request
Nov 19, 2025
…mode (#18205) ## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> - Part of #15914 ## Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> - Apache Spark's `abs()` behaves differently than DataFusion. - Apache Spark's [ANSI-compliant](https://spark.apache.org/docs/latest/sql-ref-ansi-compliance.html#ansi-compliance) dialect can be toggled by SparkConf `spark.sql.ansi.enabled`. When ANSI mode is off, arithmetic overflow doesn't throw exception like DataFusion does. - DataFusion Comet can leverage it at apache/datafusion-comet#2595 ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> - This is the 1st PR to support non-ANSI mode Spark-compatible `abs` math function - Mimics Apache Spark `v4.0.1` [abs expression](https://github.com/apache/spark/blob/v4.0.1/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala#L148) for numeric types only and non-ANSI mode, i.e. `spark.sql.ansi.enabled=false` ### Tasks breakdown | Non-ANSI mode | ANSI mode | ANSI Interval Types | | - | - | - | | this PR | hsiang-c#1 (will change base branch) | TODO | ## Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> - unit tests - sqllogictest: `test_files/spark/math/abs.slt` ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> Yes, the abs function can be specified in the SQL. - Arithmetic overflow will NOT be thrown on arithmetic overflow. <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> --------- Co-authored-by: Oleks V <comphead@users.noreply.github.com>
hsiang-c
force-pushed
the
spark_ansi_abs
branch
from
fb74a09 to
6543f08
Compare
github-actions
bot
added
documentation
logan-keede
pushed a commit
to logan-keede/datafusion
that referenced
this pull request
Nov 23, 2025
…mode (apache#18205) ## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes apache#123` indicates that this PR will close issue apache#123. --> - Part of apache#15914 ## Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> - Apache Spark's `abs()` behaves differently than DataFusion. - Apache Spark's [ANSI-compliant](https://spark.apache.org/docs/latest/sql-ref-ansi-compliance.html#ansi-compliance) dialect can be toggled by SparkConf `spark.sql.ansi.enabled`. When ANSI mode is off, arithmetic overflow doesn't throw exception like DataFusion does. - DataFusion Comet can leverage it at apache/datafusion-comet#2595 ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> - This is the 1st PR to support non-ANSI mode Spark-compatible `abs` math function - Mimics Apache Spark `v4.0.1` [abs expression](https://github.com/apache/spark/blob/v4.0.1/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala#L148) for numeric types only and non-ANSI mode, i.e. `spark.sql.ansi.enabled=false` ### Tasks breakdown | Non-ANSI mode | ANSI mode | ANSI Interval Types | | - | - | - | | this PR | hsiang-c#1 (will change base branch) | TODO | ## Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> - unit tests - sqllogictest: `test_files/spark/math/abs.slt` ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> Yes, the abs function can be specified in the SQL. - Arithmetic overflow will NOT be thrown on arithmetic overflow. <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> --------- Co-authored-by: Oleks V <comphead@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
absmath functionWhat changes are included in this PR?
Tasks breakdown
Are these changes tested?
Are there any user-facing changes?
Yes, the abs function can be specified in the SQL.