MPRIS: Restructuring and cleanup #1515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My pr addresses some of the inconsistencies in ncspot's mpris
implementation. While the previous logic was technically good enough, it
was inflexible and reported redundant information.
This will make it easier for software, that processes mpris events in
some way, to accurately react to player updates.
- 'Metadata' and 'Playback' updates have been separated into there own
command
- Mpris commands are only emitted from within spotify.rs
- Some parts of the application creation logic has been
restructured to allow for mpris events to be emitted upon startup
- The initial song loading code has been moved from 'Queue::new'
into 'Application::new'.
haruInDisguise
force-pushed
the
mpris_restructure
branch
2 times, most recently
from
75c2aa8
to
099a934
Compare
haruInDisguise
force-pushed
the
mpris_restructure
branch
from
099a934
to
29474eb
Compare
hrkfdn
reviewed
Sep 19, 2024
I've added a clippy exception so it does not complain to us about enum variants starting with the same prefix.
|
I've chosen my naming convention (:p) and also added an exception so clippy does not complain to us about enums starting with the same prefix. |
hrkfdn
approved these changes
Sep 19, 2024
|
Looks good, let's get it in + sorry for the delay! :) |
|
No worries! Thanks for taking the time! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
My pr addresses some of the inconsistencies in ncspot's mpris
implementation. While the previous logic is technically good enough, it
is inflexible and reports redundant information.
I've tried to address those issues to make it easier for software, that processes mpris events in
some way, to accurately react to player updates.
command
restructured to allow for mpris events to be emitted upon startup
into 'Application::new'.
Issue ticket number and link
This closes #1514
Checklist before requesting a review
not performance improvements, etc.)
Edit: An example of software that requires strict MPRIS compliance would be the MPRIS module for yambar that I am working on.