Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cursive to 0.21.0 #1493

Merged
merged 2 commits into from
Aug 4, 2024
Merged

Update cursive to 0.21.0 #1493

merged 2 commits into from
Aug 4, 2024

Conversation

gyscos
Copy link
Contributor

@gyscos gyscos commented Aug 3, 2024

Describe your changes

This updates cursive to 0.21.0. This release includes a buffered backend internally, so there is no need for a separate cursive_buffered_backend crate.

The main change is that View now require Send + Sync, so generic views should forward these requirements.
Note that the actual views here were already Send + Sync, and no logic change was needed.

Issue ticket number and link

Checklist before requesting a review

  • Documentation was updated (i.e. due to changes in keybindings, commands, etc.)
  • Changelog was updated with relevant user-facing changes (eg. not dependency updates,
    not performance improvements, etc.)

@gyscos
Copy link
Contributor Author

gyscos commented Aug 3, 2024

I think the CI failure is caused by the new ncurses crate requiring a proper TERM variable to be set (for example to xterm) during compilation, since it relies on ncurses itself in the build script to "discover" some constants.

Workarounds include injecting TERM=xterm in the CI process, or dropping the ncurses backend entirely.
I'm adding a commit to this PR to do the former, but it could be dropped it the latter is preferred instead.

@hrkfdn
Copy link
Owner

hrkfdn commented Aug 4, 2024

Thanks for the PR ❤️, LGTM! The CD workflows probably also need TERMto be adjusted, but we/I can figure this out later.

@hrkfdn hrkfdn merged commit 02f72b1 into hrkfdn:main Aug 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants