refactor: remove unused screenchange variable
#1205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `screenchange` member variable on `Layout` didn't seem to be used for anything except for debugging. A comment in `on_layout` makes it seem like it wasn't meant to be used for debugging purposes but for actual functionality that wasn't implemented.
|
Back with more insane space savings, a whole 1 byte this time 😝 I was adding some documentation to I just thought I'd remove it to clean up the code and avoid confusion about what this variable is for. |
|
Indeed, looks like a leftover. Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
screenchangemember variable onLayoutdidn't seem to be used for anything except for debugging. A comment inon_layoutmakes it seem like it wasn't meant to be used for debugging purposes but for actual functionality that wasn't implemented.