Skip to content

Commit

Permalink
Remove unused include. (facebook#19548)
Browse files Browse the repository at this point in the history
Summary:
`LayoutableShadowNode.cpp` includes `"LayoutableShadowNode.h"` as well as `<fabric/core/LayoutContext.h>`. In turn, `LayoutContext.h` then includes `<fabric/core/LayoutableShadowNode.h>`. `LayoutContext.h` doesn't actually require `LayoutableShadowNode.h`, but this unnecessary inclusion can cause duplicate definition errors if the two include paths don't map to exactly the same file. This patch removes the unnecessary include.

The CI's build system should cover the testing needed.

[INTERNAL] [MINOR] [fabric] - Remove an unnecessary include in fabric/core/layout.
Closes facebook#19548

Differential Revision: D8313337

Pulled By: shergin

fbshipit-source-id: 2e01e29ff25131543d9a8601483c2e716c7437be
  • Loading branch information
sayrer authored and facebook-github-bot committed Jun 7, 2018
1 parent 9cc14ec commit 79c5b8e
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions ReactCommon/fabric/core/layout/LayoutContext.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,6 @@

#pragma once

#include <unordered_set>

#include <fabric/core/LayoutableShadowNode.h>
#include <fabric/graphics/Geometry.h>

namespace facebook {
Expand Down

0 comments on commit 79c5b8e

Please sign in to comment.