Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add devtron condition to devtools extension loader #238

Merged
merged 5 commits into from Mar 3, 2018
Merged

add devtron condition to devtools extension loader #238

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
65e407a
Merge branch 'dev-upstream' into dev
jens-struct Mar 1, 2018
263e568
Merge branch 'dev-upstream' into dev
jens-struct Mar 2, 2018
b124dfd
added info about devtools
jens-struct Mar 2, 2018
65cf9a0
remove readme changes
jens-struct Mar 2, 2018
c5cf687
Merge branch 'dev' into devtools-additional-info
hql287 Mar 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,8 @@ function createPreviewWindow() {
}

function addDevToolsExtension() {
if (process.env.DEVTRON_DEV_TOOLS_PATH)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would be the value of DEVTRON_DEV_TOOLS_PATH if I decided to use it?

Copy link
Author

@ghost ghost Mar 3, 2018 •
edited by ghost
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that would be the node_modules path, as it is part of the devDependencies:
DEVTRON_DEV_TOOLS_PATH=./node_modules/devtron

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works! 😆

BrowserWindow.addDevToolsExtension(process.env.DEVTRON_DEV_TOOLS_PATH);
if (process.env.REACT_DEV_TOOLS_PATH)
BrowserWindow.addDevToolsExtension(process.env.REACT_DEV_TOOLS_PATH);
if (process.env.REDUX_DEV_TOOLS_PATH)
Expand Down