Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inverted comma #223

Closed
wants to merge 9 commits into from
Closed

Inverted comma #223

wants to merge 9 commits into from

Conversation

marcobischoff
Copy link
Contributor

#222 As there are some countries which uses the inverted comma as thousand separator I've added this to the currency.

Bring fork up to date
Some countries uses the inverted comma as a thousander separator
HTML entities
Snapshot
@hql287
Copy link
Owner

hql287 commented Feb 19, 2018

Hah, this is interesting. How do you type the inverted comma on a US keyboard?

@marcobischoff
Copy link
Contributor Author

You‘re right, the inverted comma is not the right char; instead it is an apostrophe which is used and this should also be available on an US keyboard. I will make ab update on this.

@hql287
Copy link
Owner

hql287 commented Feb 19, 2018

Yup, it seems that you're using right single quote ’

@hql287
Copy link
Owner

hql287 commented Feb 19, 2018

Let's resolve #129 first then we can merge this.
Please take a look at #224 and let me know if you want to change or add anything to it.
Thanks.

@hql287
Copy link
Owner

hql287 commented Feb 20, 2018

@marcobischoff: Why do you try to solve #220 with this PR? I'm confused. Also, please use styled-component instead of plain CSS.

I think it would be best if you create a clean (new) PR with only the changes necessary to fix #222.
Btw, what countries use inverted comma/ apostrophe as the thousand separator, I'm curious?

@marcobischoff
Copy link
Contributor Author

marcobischoff commented Feb 20, 2018

@hql287 My repo is/was a little bit messed up. I will create a new PR.
Switzerland is a country which use this.

@hql287
Copy link
Owner

hql287 commented Feb 20, 2018

@marcobischoff Thanks! 👍

@hql287 hql287 closed this Feb 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants