Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

German string translation and selection #221

Closed
wants to merge 3 commits into from
Closed

German string translation and selection #221

wants to merge 3 commits into from

Conversation

marcobischoff
Copy link
Contributor

#207 This is the german language and selection of if in the "General" tab in the "Settings" view.

@hql287
Copy link
Owner

hql287 commented Feb 19, 2018

Shouldn't this be part of #207?

@marcobischoff
Copy link
Contributor Author

Would make sense, how can I add this to #207 new PR?

@hql287
Copy link
Owner

hql287 commented Feb 19, 2018

You can create a new PR to the branch of the #217 PR

@hql287
Copy link
Owner

hql287 commented Feb 19, 2018

But I would suggest waiting until I resolve the current conflict on that branch first. Will do it after either #216 or #224 is merged.

@hql287 hql287 closed this Feb 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcobischoff @hql287