Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly handle recipient information in edit mode #203

Merged
merged 5 commits into from
Feb 3, 2018
Merged

Correctly handle recipient information in edit mode #203

merged 5 commits into from
Feb 3, 2018

Conversation

hql287
Copy link
Owner

@hql287 hql287 commented Feb 3, 2018 •
edited
Loading

  • When the contacts list is empty, the contact information saved in the invoice record will be used in recipient form to create a new one
  • When the contacts list is not empty, the current contact will be selected correctly in the dropdown

Fix #197

hql287 added 4 commits February 3, 2018 17:52
@hql287
Refactor form helper
e9b4355 
+ Add _id and created_at date to recipient data so invoice will also save new contact id => easier to reference later
+ Add setEditRecipient helper to set correct recipient information to use in edit mode
@hql287
Make sure newContact data has _id and created_at data
e6ed074
@hql287
Pass allContacts to INVOICE_EDIT action to check later
9e87ec0
@hql287
Refactored FormReducer INVOICE_EDIT action
ea779a9 
Use new helper to return correct recipient data in edit mode
@hql287 hql287 added the bug label Feb 3, 2018
@hql287 hql287 self-assigned this Feb 3, 2018
@hql287 hql287 merged commit 4f0392b into dev Feb 3, 2018
@hql287 hql287 deleted the fix-197 branch February 4, 2018 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hql287 hql287

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hql287