Correctly convert number to string - #39
Open
klismannsm wants to merge 1 commit into
Open
Conversation
klismannsm
marked this pull request as draft
September 21, 2022 12:10
klismannsm
force-pushed
the
klismannsm/fix-number-as-string
branch
from
September 22, 2022 12:55
950e87c to
7328de0
Compare
klismannsm
marked this pull request as ready for review
September 22, 2022 12:55
wdesimini
reviewed
Oct 6, 2022
| } | ||
|
|
||
| - (NSString *) getValueAsString:(NSString *)key{ | ||
| return [NSString stringWithFormat:@"%@", [self getValue:key]]; |
Contributor
There was a problem hiding this comment.
Might want to allow for [self getValue:key] to be nullable here.
cc @lundhjem
Contributor
Author
There was a problem hiding this comment.
Good catch! Done.
When fetching the data from a UPA response, number values were not being correctly converted to string.
klismannsm
force-pushed
the
klismannsm/fix-number-as-string
branch
from
October 6, 2022 20:08
7328de0 to
bd7e072
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When fetching the data from a UPA response, number values were not being correctly converted to string.