Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS refactoring #252

Merged
merged 11 commits into from
Sep 15, 2024
Merged

CSS refactoring #252

merged 11 commits into from
Sep 15, 2024

Conversation

ai
Copy link
Contributor

@ai ai commented Sep 14, 2024

  • Move to global CSS to fix Svelte issues and allow user style changes
  • Move PostCSS plugins from JS to TS
  • Move Remark config from JS to JSON
  • Fix Stylelint conflict with Prettier
  • Remove Harmony to define colors manually and have more flexability

@ai ai changed the title Css refactor CSS refactoring Sep 14, 2024
Copy link
Contributor

Pull request auto-reviewer

  • Don’t rush. Check all changes in PR again.

  • Run pnpm test.

  • Think about changing documentation.

    • If you added a script to scripts/, add a comment with a description.
    • If you added a new folder, add its description to the project’s README.md.
    • If you added config, describe how we use this tool in the config’s comment.
    • Try to focus on “why?”, not “how?”.
  • Think about code testing.

  • If you added a new dependency, check our requirements.

  • Think about moving code to core/. What code will also be useful on other platforms?

  • Think about HTML semantics.

  • Think about accessibility. Try to search for a11y recommendations for your case. Think about how screen reader users will use the tool. Is it easy to use on a screen with bad contrast?

  • The UI was checked in Chrome and Firefox (and Safari or Epiphany if you have them).

Copy link
Contributor

Pull request auto-reviewer

  • Since you’ve made changes to files in web/main/ consider these points:
    1. Do you need to backport styles changes to web/public/404.html or web/public/500.html?
    2. Think about app loading styles inlined in index.html.

@ai ai merged commit b456568 into main Sep 15, 2024
12 checks passed
@ai ai deleted the css-refactor branch September 15, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant