New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pnpm deploy to created server with minimum dependencies #242

Merged

ai merged 1 commit into main from pnpm-deploy-pnpm

Aug 21, 2024

Contributor

ai commented Aug 21, 2024

To protect ourselves from supply chain attack we need to install minimum during server deploy.

Our previous esbuild approach was too hardcore and do not scale to WS server.

pnpm deploy does almost the same. Also we need to compile TS to JS anymore.


          Use pnpm deploy to created server with minimum dependencies

9c341e1

Contributor

github-actions bot commented Aug 21, 2024

Pull request auto-reviewer

Don’t rush. Check all changes in PR again.
Run pnpm test.
Think about changing documentation.
- If you added a script to scripts/, add a comment with a description.
- If you added a new folder, add its description to the project’s README.md.
- If you added config, describe how we use this tool in the config’s comment.
- Try to focus on “why?”, not “how?”.
Think about code testing.
If you added a new dependency, check our requirements.

ai merged commit f23f501 into main

9 checks passed

ai deleted the pnpm-deploy-pnpm branch

August 21, 2024 23:02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet