-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move from asdf to Dev Container #202
Conversation
@ai, what exactly do I need to test? I've already tried running pnpm test, and I've noticed a perceptible slowdown when using the development container. Although it's still usable, the difference in performance is noticeable. macOS M1 in dev container:pnpm test 142.77s user 40.95s system 343% cpu 53.452 total macOS M1 in asdf
( |
AFAIU it's not asdf causing the problems, it's pnpm. pnpm is trying to be an alternative not only for npm, but also for nvm for whatever reason. And if the console in the current folder shows that Node 22 is being used, pnpm is still using Node 20 under the hood. At least this is the problem I had with Volta |
@baileys-li sad. On Linux I have no big difference in performance. Don’t worry, you can still install everything locally and run without VM. |
For the first time in my life, I decided to try to do something in the open source project, and decided to do everything as Andrei told to do, run through containers. The launch failed))) 😄 Mackbook M1 |
@mike-minchenko what error did you have? We may need a little tuning for Docker and Mac. |
@mike-minchenko what way do you use to run Docker images? |
Via Devcontainers in VSCode |
@mike-minchenko I mean what tool do you have to run Docker images in the system? Maybe you use Docker Desktop for Intel? Can you tried to run other Docker images on your system? |
I'm using Docker Desktop for Apple Silicon. I can run other images. I'm not very familiar with Docker and its settings. |
Right now we use
asdf
to sync environment. It has a few problems:asdf
has conflict withnvm
. The conflict behavior is very strange and user can spend a lot of time finding the source of issue.node_modules
may contain malware. It should not have full access to user’s home folder with credentials JSONs and private files. Dev Container isolate project.Risks: