-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix README dependencies link in PR body #176
Conversation
docs/pull_request_template.md
Outdated
@@ -20,7 +20,7 @@ Fixes # (PUT ISSUE NUMBER AFTER #) | |||
- If you added config, describe how we use this tool in the config’s comment. | |||
- If you added something to the project’s architecture, describe it in the project’s `README.md`. | |||
- Try to focus on “why?”, not “how?”. | |||
- [ ] If you added a new dependency, check our [requirements](../README.md#dependencies). | |||
- [ ] If you added a new dependency, check our [requirements](/hplush/slowreader/blob/main/README.md#dependencies). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The case you described is not common as the file is intended to be interacted with through the pull request page but I fixed it though. Let's hope github doesn't change its URL soon
Thanks. Now the link works. |
No issue
Motivation
wanted to improve DX
Screenshot or Video
pretty minor change for a video
Checklist
pnpm test
.scripts/
, add a comment with a description.README.md
.README.md
.core/
. What code will also be useful on other platforms?pnpm size
and check the difference in the JS bundle size. Is it relevant to the changes? Change the limit inweb/.size-limit.json
if necessary.web/main/
files:web/public/404.html
orweb/public/500.html
?index.html
.core/
: