Update Node.js by adding hack to fix Storybook

hplush · Jan 12, 2025 · c8857e4 · c8857e4
1 parent ab18a31
commit c8857e4
Show file tree

Hide file tree

Showing 13 changed files with 50 additions and 58 deletions.
diff --git a/.devcontainer/Dockerfile b/.devcontainer/Dockerfile
@@ -5,12 +5,12 @@ FROM docker.io/ubuntu:24.04
 
 ARG TARGETARCH
 
-ENV NODE_VERSION 22.11.0
+ENV NODE_VERSION 22.13.0
 ENV PNPM_VERSION 10.0.0
 
-ENV NODE_CHECKSUM_ARM64 27453f7a0dd6b9e6738f1f6ea6a09b102ec7aa484de1e39d6a1c3608ad47aa6a
+ENV NODE_CHECKSUM_ARM64 e0cc088cb4fb2e945d3d5c416c601e1101a15f73e0f024c9529b964d9f6dce5b
 ENV PNPM_CHECKSUM_ARM64 9bb1b569890eee8a7f535fadda6f9a78ffeb818a780b8c591e92478089eafafd
-ENV NODE_CHECKSUM_X64 4f862bab52039835efbe613b532238b6e4dde98d139a34e6923193e073438b13
+ENV NODE_CHECKSUM_X64 9a33e89093a0d946c54781dcb3ccab4ccf7538a7135286528ca41ca055e9b38f
 ENV PNPM_CHECKSUM_X64 e1025c55ae220c66a980272ecb343c4860b129687e4e1c41bc5f343ee127d455
 
 RUN apt-get update \

diff --git a/.node-version b/.node-version
@@ -1 +1 @@
-22.11.0
+22.13.0
diff --git a/api/package.json b/api/package.json
@@ -3,7 +3,7 @@
   "private": true,
   "type": "module",
   "engines": {
-    "node": "^22.11.0",
+    "node": "^22.13.0",
     "pnpm": "^10.0.0"
   },
   "exports": {

diff --git a/core/package.json b/core/package.json
@@ -3,7 +3,7 @@
   "private": true,
   "type": "module",
   "engines": {
-    "node": "^22.11.0",
+    "node": "^22.13.0",
     "pnpm": "^10.0.0"
   },
   "scripts": {

diff --git a/extension/package.json b/extension/package.json
@@ -3,7 +3,7 @@
   "private": true,
   "type": "module",
   "engines": {
-    "node": "^22.11.0",
+    "node": "^22.13.0",
     "pnpm": "^10.0.0"
   },
   "scripts": {

diff --git a/loader-tests/package.json b/loader-tests/package.json
@@ -3,7 +3,7 @@
   "private": true,
   "type": "module",
   "engines": {
-    "node": "^22.11.0",
+    "node": "^22.13.0",
     "pnpm": "^10.0.0"
   },
   "scripts": {

diff --git a/package.json b/package.json
@@ -4,7 +4,7 @@
   "private": true,
   "type": "module",
   "engines": {
-    "node": "^22.11.0",
+    "node": "^22.13.0",
     "pnpm": "^10.0.0"
   },
   "packageManager": "[email protected]",

diff --git a/proxy/Dockerfile b/proxy/Dockerfile
@@ -1,8 +1,8 @@
 # syntax=docker/dockerfile:1.6
 FROM registry.access.redhat.com/ubi9/ubi:9.4 as builder
 
-ENV NODE_VERSION 22.11.0
-ENV NODE_CHECKSUM sha256:4f862bab52039835efbe613b532238b6e4dde98d139a34e6923193e073438b13
+ENV NODE_VERSION 22.13.0
+ENV NODE_CHECKSUM sha256:9a33e89093a0d946c54781dcb3ccab4ccf7538a7135286528ca41ca055e9b38f
 
 ADD --checksum=$NODE_CHECKSUM https://nodejs.org/dist/v${NODE_VERSION}/node-v${NODE_VERSION}-linux-x64.tar.gz /node.tar.gz
 RUN tar --remove-files -C /usr/local/ -xz --strip-components=1 -f /node.tar.gz

diff --git a/proxy/package.json b/proxy/package.json
@@ -3,7 +3,7 @@
   "private": true,
   "type": "module",
   "engines": {
-    "node": "^22.11.0",
+    "node": "^22.13.0",
     "pnpm": "^10.0.0"
   },
   "exports": {

diff --git a/scripts/update-env.ts b/scripts/update-env.ts
@@ -30,17 +30,17 @@ async function getLatestPnpmVersion(): Promise<string> {
   return data.tag_name.slice(1)
 }
 
-// async function getNodeSha256(version: string): Promise<Architectures> {
-//   let response = await fetch(
-//     `https://nodejs.org/dist/v${version}/SHASUMS256.txt`
-//   )
-//   let data = await response.text()
-//   let lines = data.split('\n')
-//   return {
-//     arm64: lines.find(i => i.endsWith('-linux-arm64.tar.gz'))!.split(' ')[0]!,
-//     x64: lines.find(i => i.endsWith('-linux-x64.tar.gz'))!.split(' ')[0]!
-//   }
-// }
+async function getNodeSha256(version: string): Promise<Architectures> {
+  let response = await fetch(
+    `https://nodejs.org/dist/v${version}/SHASUMS256.txt`
+  )
+  let data = await response.text()
+  let lines = data.split('\n')
+  return {
+    arm64: lines.find(i => i.endsWith('-linux-arm64.tar.gz'))!.split(' ')[0]!,
+    x64: lines.find(i => i.endsWith('-linux-x64.tar.gz'))!.split(' ')[0]!
+  }
+}
 
 async function getPnpmSha256(
   version: string,
@@ -68,14 +68,14 @@ function updatePackages(cb: (content: string) => string): void {
   }
 }
 
-// function updateProjectDockerfiles(cb: (content: string) => string): void {
-//   let files = globSync(['**/Dockerfile', '.devcontainer/Dockerfile'])
-//   for (let file of files) {
-//     let content = read(file)
-//     let updated = cb(content)
-//     writeFileSync(file, updated)
-//   }
-// }
+function updateProjectDockerfiles(cb: (content: string) => string): void {
+  let files = globSync(['**/Dockerfile', '.devcontainer/Dockerfile'])
+  for (let file of files) {
+    let content = read(file)
+    let updated = cb(content)
+    writeFileSync(file, updated)
+  }
+}
 
 function printUpdate(tool: string, prev: string, next: string): void {
   process.stderr.write(
@@ -120,32 +120,24 @@ let latestNode = await getLatestNodeVersion(
   process.argv[2] ?? currentNode.split('.')[0]!
 )
 let latestPnpm = await getLatestPnpmVersion()
+latestPnpm = '10.0.0'
 
 if (currentNode !== latestNode) {
-  // printUpdate('Node.js', currentNode, latestNode)
-  // let checksums = await getNodeSha256(latestNode)
-  // dockerfile = replaceVersionEnv(dockerfile, 'NODE', latestNode, checksums)
-
-  // Until https://github.com/storybookjs/addon-svelte-csf/issues/229
-  // will be fixed, we can’t update Node.js
-  process.stderr.write(
-    styleText(
-      'yellow',
-      `Skipping Node.js ${latestNode} update due to Storybook issue\n`
-    )
-  )
+  printUpdate('Node.js', currentNode, latestNode)
+  let checksums = await getNodeSha256(latestNode)
+  dockerfile = replaceVersionEnv(dockerfile, 'NODE', latestNode, checksums)
 
-  // writeFileSync(join(ROOT, '.devcontainer', 'Dockerfile'), dockerfile)
-  // writeFileSync(join(ROOT, '.node-version'), latestNode + '\n')
+  writeFileSync(join(ROOT, '.devcontainer', 'Dockerfile'), dockerfile)
+  writeFileSync(join(ROOT, '.node-version'), latestNode + '\n')
 
-  // updateProjectDockerfiles(projectDocker => {
-  //   return replaceVersionEnv(projectDocker, 'NODE', latestNode, checksums)
-  // })
+  updateProjectDockerfiles(projectDocker => {
+    return replaceVersionEnv(projectDocker, 'NODE', latestNode, checksums)
+  })
 
-  // let minor = latestNode.split('.').slice(0, 2).join('.')
-  // if (currentNode.split('.').slice(0, 2).join('.') !== minor) {
-  //   updatePackages(pkg => replaceKey(pkg, 'node', `^${minor}.0`))
-  // }
+  let minor = latestNode.split('.').slice(0, 2).join('.')
+  if (currentNode.split('.').slice(0, 2).join('.') !== minor) {
+    updatePackages(pkg => replaceKey(pkg, 'node', `^${minor}.0`))
+  }
 }
 
 if (currentPnpm !== latestPnpm) {

diff --git a/server/Dockerfile b/server/Dockerfile
@@ -1,8 +1,8 @@
 # syntax=docker/dockerfile:1.6
 FROM registry.access.redhat.com/ubi9/ubi:9.4 as builder
 
-ENV NODE_VERSION 22.11.0
-ENV NODE_CHECKSUM sha256:4f862bab52039835efbe613b532238b6e4dde98d139a34e6923193e073438b13
+ENV NODE_VERSION 22.13.0
+ENV NODE_CHECKSUM sha256:9a33e89093a0d946c54781dcb3ccab4ccf7538a7135286528ca41ca055e9b38f
 
 ADD --checksum=$NODE_CHECKSUM https://nodejs.org/dist/v${NODE_VERSION}/node-v${NODE_VERSION}-linux-x64.tar.gz /node.tar.gz
 RUN tar --remove-files -C /usr/local/ -xz --strip-components=1 -f /node.tar.gz

diff --git a/server/package.json b/server/package.json
@@ -3,7 +3,7 @@
   "private": true,
   "type": "module",
   "engines": {
-    "node": "^22.11.0",
+    "node": "^22.13.0",
     "pnpm": "^10.0.0"
   },
   "scripts": {

diff --git a/web/package.json b/web/package.json
@@ -3,22 +3,22 @@
   "private": true,
   "type": "module",
   "engines": {
-    "node": "^22.11.0",
+    "node": "^22.13.0",
     "pnpm": "^10.0.0"
   },
   "scripts": {
     "test": "pnpm run /^test:/",
     "build": "pnpm run /^build:/ && mv ./storybook-static ./dist/ui",
     "start": "vite",
-    "visual": "storybook dev -p 6006 --no-open",
+    "visual": "NODE_OPTIONS='--no-experimental-require-module' storybook dev -p 6006 --no-open",
     "production": "node --run build && ./scripts/run-image.sh",
     "size": "node --run build:web && size-limit",
     "test:unit": "pnpm bnt",
     "test:names": "../scripts/tsnode ./scripts/check-names.ts",
     "test:css": "stylelint **/*.css **/*.svelte",
     "test:build": "node --run build && size-limit && ../scripts/tsnode ./scripts/check-css-props.ts",
     "build:routes": "../scripts/tsnode ./scripts/export-routes.ts",
-    "build:visual": "NODE_ENV=test storybook build",
+    "build:visual": "NODE_OPTIONS='--no-experimental-require-module' NODE_ENV=test storybook build",
     "build:web": "vite build && ../scripts/tsnode scripts/generate-csp.ts",
     "format:stylelint": "stylelint --fix **/*.{css,svelte}",
     "clean:build": "rm -rf dist"