Refactor: Execute linter rules all at once to save time

packages/AlgernonTests.package/ALGLinting.class/instance/collectTestObjects.st

@@ -0,0 +1,6 @@
+helpers
+collectTestObjects
+	| classes |
+	classes := SystemNavigation default allClasses.
+	classes := classes select: [ :each | each class category beginsWith: 'Algernon' ].
+	^ classes collect: [ :each | each as: SLTestObject ].

packages/AlgernonTests.package/ALGLinting.class/instance/evaluateClassTests..st

@@ -0,0 +1,9 @@
+helpers
+evaluateClassTests: aCollection
+	| positiveResults |
+	positiveResults := aCollection select: [ :classTest | 
+		(classTest methods select: [ :methodTest | 
+			(self evaluateMethodTest: methodTest) size > 0]) size > 0].
+
+	(positiveResults size > 0) ifTrue: [
+		self signalFailure: 'ALGLint found problems in ' , positiveResults size asString , ' class(es). (See Transcript or log above)'].

packages/AlgernonTests.package/ALGLinting.class/instance/evaluateMethodTest..st

@@ -0,0 +1,15 @@
+helpers
+evaluateMethodTest: aSLMethodTest
+	| results |
+	results := aSLMethodTest results.
+	^ results select: [ :result |
+		result value ifTrue: [
+			Transcript cr.
+			Transcript show: '=== ALGLint Failure ==='.
+			Transcript cr.
+			Transcript show: '''' , aSLMethodTest name , ''' failed on ''' , result testData name , '''.'.
+			Transcript cr.
+			Transcript show: 'Description: ' , result testData description.
+			Transcript cr.].
+		result value]
+

packages/AlgernonTests.package/ALGLinting.class/instance/lintingRules.st

@@ -0,0 +1,82 @@
+helpers
+lintingRules
+	^ {
+		"Bugs"
+		#smallLintBooleanPrecedence.
+		#smallLintMethodModifierFinal.
+		#smallLintMethodModifierSuper.
+		#smallLintMethodModifierOverride.
+		#smallLintUsesTrue.
+		#smallLintOverridesSpecialMessage.
+		#smallLintSubclassResponsibilityNotDefined.
+		#smallLintMethodModifierSuper.
+		#smallLintUndeclaredReference.
+		#smallLintSendsUnknownMessageToGlobal.
+		#smallLintVariableNotDefined.
+
+		"Possible Bugs"
+		#smallLintAddRemoveDependents.
+		#smallLintAbstractClass.
+		#smallLintClassInstVarNotInitialized.
+		#smallLintEmptyExceptionHandler.
+		#smallLintDefinesEqualNotHash.
+		#smallLintFloatEqualityComparison.
+		#smallLintLiteralArrayContainsComma.
+		#smallLintLiteralArrayContainsSuspiciousTrueFalseOrNil.
+		#smallLintCollectionCopyEmpty.
+		#smallLintReturnsIfTrue.
+		#smallLintReturnInEnsure.
+		#smallLintTempsReadBeforeWritten.
+		#smallLintThreeElementPoint.
+		#smallLintUncommonMessageSend.
+		#smallLintUnconditionalRecursion.
+		#smallLintUnpackagedCode.
+		#smallLintEqualNotUsed.
+		#smallLintFileBlocks.
+		#smallLintUsesAdd.
+
+		"Code-Style"
+		#smallLintDefinesEqualNotHash.
+		#smallLintEqualNotUsed.
+		#smallLintEqualsTrue.
+		#smallLintExtraBlock.
+		#smallLintJustSendsSuper.
+		#smallLintMethodModifierOverride.
+		#smallLintReturnsIfTrue.
+		#smallLintWhileTrue.
+
+		"Intention revealing"
+		#smallLintClassVariableCapitalization.
+		#smallLintContains.
+		#smallLintDetectContains.
+		#smallLintLiteralArrayCharacters.
+		#smallLintMissingSubclassResponsibility.
+		#smallLintSearchingLiteral.
+		#smallLintSizeCheck.
+		#smallLintTemporaryVariableCapitalization.
+		#smallLintCollectSelectNotUsed.
+
+		"Spelling"
+		#smallLintClassCategoriesSpelling.
+		#smallLintClassVariableNamesSpelling.
+
+		"Unnecessary code"
+		#smallLintAssignmentWithoutEffect.
+		#smallLintEndTrueFalse.
+		#smallLintJustSendsSuper.
+		#smallLintEqualsTrue.
+		#smallLintExtraBlock.
+		#smallLintUnreferencedVariables.
+
+		"Miscellaneous"
+		#smallLintAsOrderedCollectionNotNeeded.
+		#smallLintAssignmentInBlock.
+		#classNameInSelector:.
+		#smallLintExcessiveInheritance.
+		#smallLintIfTrueBlocks.
+		#smallLintStringConcatenation.
+		#smallLintUnclassifiedMethods.
+		#smallLintUnoptimizedAndOr.
+		#smallLintUnoptimizedToDo.
+		#smallLintYourselfNotUsed.
+	}

packages/AlgernonTests.package/ALGLinting.class/instance/testLinting.st

@@ -0,0 +1,9 @@
+helpers
+testLinting
+	"Test all Algernon methods for all rules defined in #lintingRules"
+	| testRunner testObjects |
+	testRunner := (SLTestRunner new) environment: (SLDefaultEnvironment new).
+	testObjects := self collectTestObjects.
+
+	testRunner runOnTests: self lintingRules andTestObjects: testObjects.
+	self evaluateClassTests: testObjects.