WIP: debian package update #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
no need to abuse the pwd shell command, we have a handy DESTDIR variable, which the makefile should respect too. but because we need to pass PREFIX anyways (since we need to override the correct upstream default, /usr/local) it's probably not worth implementing DESTDIR in the Makefile...
|
okay, i think i'm about done here - the only WIP left here is the question of the CHANGES vs debian/changelog files... |
@SaveTheRbtz was the one that originally packaged this in hoytech#1, i thought it was upstream...
|
Thank you! Let's not do a systemd unit file for now. My only concern is, as you mentioned, the CHANGES/changelog split. I'd really prefer not maintaining 2 of them, and if possible not breaking the existing format. Is the format you've created required by debian? |
|
I see you added instructions on how to maintain the changelog file in the PR. I'm merging your branch now, thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
those are the changes I was thinking about in #47.
most of those are minor maintenance changes that you won't need to do in the future. only changes like 36e013d would be necessary on a regular basis.
as you can see, you will need to decide if you use
debian/changelogorCHANGESas your main changelog. in my native packages, i just symlink the two together (example) and maintain everything indebian/changelog, but you may not like the format.also note that the 1.2.1 release is marked as UNRELEASED. this means the release is not completed just yet, and tools (like
gbp dch) will keep on adding new entries from your git history (automatically!) when you add stuff to the history.another improvement that could be done would be to ship a systemd
.servicefile, since it makes it easier to manage the service since Debian jessie.init.dfiles still work, of course, and we can keep on shipping it for those users who do not want or cannot run systemd... it would also be useful for other distros.