Kotlin Version #15
Kotlin Version #15
Conversation
…se of java collections Adds benchmark cases Refactors for simplicity.
Fixes bug with indexes not updating Adds a multiple round test
adds fingerprint benchmark and multiround benchmark tests
|
This PR is now all set and running the tests perfectly. |
…ng including overhead.
Add explainers Uses native binary search instead of custom-made Uses native comparators instead of custom functions
|
Thanks for this! I'm OK with merging this as-is, but most of the third-party implementations have so far preferred to keep their code in their own repos, and I will link to it in the Implementations section. It may be more convenient for you since I won't have to approve every future modification you make. Let me know what you'd prefer. |
|
I can do either. Whatever is easy to keep testing all these versions for compliance. I can move it to my own repo and prepare a kotlin lib for others to use or copy this code over there. We might need to have a little script that downloads all versions and tests them all against each other. |
|
Cool, then let's keep the core Kotlin implementation in your repo to keep it consistent with the other implementations. Good idea about making a single system for testing all the different implementations. Maybe we can make a parent repo that submodules in all the implementations. |
|
Awesome! I will move this over and change this PR accordingly. |
# Conflicts: # README.md # test/Utils.pm
Kotlin's implementation of Negentropy.