This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Add Facebook Handover Protocol #978
Merged
benbrown
merged 32 commits into
howdyai:master
from
ouadie-lahdioui:feature/facebookHandoverProtocol
Jan 18, 2018
Merged
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
4be0b65
:dancers: handle app roles event
ouadie-lahdioui 0281ceb
:scream_cat: add lodash
ouadie-lahdioui 8d66320
:nail_care: handle facebook_standby
ouadie-lahdioui f529e14
:feet: handle facebook_pass_thread_control
ouadie-lahdioui 3703044
:eyes: handle facebook_take_thread_control
ouadie-lahdioui 2c4fd3c
:see_no_evil: Remove lodash and add a default log message when standb…
ouadie-lahdioui 96eba34
:running: Add handover_protocol and get_secondary_receivers_list method
ouadie-lahdioui 5fc914e
:pouting_cat: add take_thread_control
ouadie-lahdioui 2ca775c
:trollface: Add pass_thread_control
ouadie-lahdioui 953f26b
:sheep: Add documentation
ouadie-lahdioui 86cc29b
Merge branch 'master' into pr-handover
jonchurch abecf88
fix for messaging pipeline
jonchurch 3dcd8cd
fix typo
jonchurch 90aaa52
typo
jonchurch 9b09e56
testing
jonchurch 1bb30f9
typos
jonchurch e9f547c
remove debug console.log
jonchurch 22d74f6
test pass_thread_control
jonchurch cfb012c
try stringify request_body
jonchurch 137c7ab
log error in pass thread
jonchurch f094da5
add error handling to pass thread
jonchurch 1587905
add debug to threadControl middleware
jonchurch ff466d3
try to fix handover api on bot
jonchurch 32a2a93
typo
jonchurch 8419f58
fix cb and json parsing for handover api calls
jonchurch 09e7cf5
fix up secondary receivers api call
jonchurch c7e9daa
work on secondary_receivers api call
jonchurch fc1baa5
add fields to secondary receiver listing
jonchurch 0e03369
remove fields param from list receiver
jonchurch d42f1f2
Merge branch 'master' into pr-handover-rebase
jonchurch afd2136
Merge pull request #1 from jonchurch/pr-handover-rebase
ouadie-lahdioui b8029ba
Resolve conflict with botkit v0.0.6
ouadie-lahdioui File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't be the opposite?
message.pass_thread_control => facebook_lose_thread_control
message.take_thread_control => facebook_receive_thread_control
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pass_thread_control callback will occur when thread ownership for a user has been passed to your application, So, in botkit y'll be able to catche that like that :
However, take_thread_control will occur when thread ownership for a user has been taken away from your application, to catche that :
@t-lopes WDYT ?