Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Adding redirectUri parameter to start bot command #510

Closed
wants to merge 1 commit into from
Closed

Adding redirectUri parameter to start bot command #510

wants to merge 1 commit into from

Conversation

josephkerkhof
Copy link

This node command fails without the redirectUri parameter being included.

This node server fails without the redirectUri parameter included in
the command.
@jonchurch
Copy link
Contributor

This was a mistake I introduced, because you don't actually need the redirectUri for the slack_button flow, it should not be necessary to run the file.

@josephkerkhof
Copy link
Author

When I tried running the starting command as instructed, it gave me an error saying that it needed the redirectUri parameter. The code that I updated was the only way for me to get the bot to launch.

@jonchurch
Copy link
Contributor

You are spot on that this is a bug, but the right fix is to make redirectUri optional and not required to run the file.

@josephkerkhof
Copy link
Author

Gotcha. That would just mean removing it from the first if-statement, correct?

@jonchurch
Copy link
Contributor

Correct, I submitted #526 to address this.

@benbrown benbrown closed this in #526 Dec 5, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants