[feature] #NAV-3079 - Ntfs2gtfs - Add ticketing_deep_links to gtfs export #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArnaudOggy
force-pushed
the
NAV-3079_gtfs2ntfs_support_gtfs_deeplinks
branch
from
83e5731 to
6334e05
Compare
woshilapin
approved these changes
Jul 3, 2024
| id: format!("ticketing_deep_link:{}", i + 1), | ||
| web_url: Some(fare_url.clone()), | ||
| android_intent_uri: Some(fare_url.clone()), | ||
| ios_universal_link_url: Some(fare_url.clone()), |
There was a problem hiding this comment.
The last one probably don't need a .clone() 🤷
Co-authored-by: Jean SIMARD <[email protected]>
datanel
reviewed
Jul 4, 2024
| .get(fare_url) | ||
| .map(|ticketing_deep_link| ticketing_deep_link.id.clone()) | ||
| }) | ||
| .or_else(|| Some(String::new())); |
There was a problem hiding this comment.
Do you need to have an empty String here ?
If I understand agency.ticketing_deep_link_id may have 3 outputs
Some("a_string_not_empty")ifticketing_deep_links IS NOT emptyandticketing_deep_links.get(fare_url)existsSome("")ifticketing_deep_links IS NOT emptyandticketing_deep_links.get(fare_url)DOES NOT existNoneifticketing_deep_links IS empty
I think if you have something like
agency.ticketing_deep_link_id = network
.fare_url
.as_ref()
.and_then(|fare_url| {
ticketing_deep_links
.get(fare_url)
.map(|ticketing_deep_link| ticketing_deep_link.id.clone())
});
}It will return Some("something") or None and None will be serialized to ""
There was a problem hiding this comment.
I added comments on the reason for this empty string 81a9cf1
datanel
approved these changes
Jul 4, 2024
ArnaudOggy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.