feat: add 'occupancies.txt' support (ntfs:v0.13.0) #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArnaudOggy
reviewed
Jan 6, 2023
pbench
previously approved these changes
Jan 6, 2023
ArnaudOggy
reviewed
Jan 6, 2023
ArnaudOggy
reviewed
Jan 6, 2023
ArnaudOggy
reviewed
Jan 6, 2023
| @@ -1,5 +1,5 @@ | |||
| feed_info_param,feed_info_value | |||
| ntfs_version,0.3 | |||
| ntfs_version,0.13.0 | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
ArnaudOggy
previously approved these changes
Jan 9, 2023
patochectp
reviewed
Jan 9, 2023
woshilapin
requested review from
patochectp,
pbench and
ArnaudOggy
and removed request for
pbench
ArnaudOggy
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing support for the new version of NTFS (not released yet, see hove-io/ntfs-specification#38).
sanitizeis not ideal because it could go a step further by removingOccupancywhen:vehicle_journeyof the line is traveling on the intervalfrom_date-to_datefrom_stop_areais afterto_stop_areaon allvehicle_journeyof the line