Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] drop vj without growing stop times #820

Merged
merged 3 commits into from
Oct 27, 2021
Merged

Conversation

woshilapin
Copy link
Contributor

Remove the vehicle journey if the stop times don't have ordered departure_time/arrival_time.

ref: ND-1672

@woshilapin woshilapin requested a review from patochectp October 25, 2021 14:18
patochectp
patochectp previously approved these changes Oct 25, 2021
@ArnaudOggy

This comment has been minimized.

ArnaudOggy
ArnaudOggy previously approved these changes Oct 25, 2021
@woshilapin woshilapin dismissed stale reviews from ArnaudOggy and patochectp via 3d9304c October 26, 2021 13:01
@woshilapin
Copy link
Contributor Author

@woshilapin Note that the production of incorrect ntfs will always be possible. There we correct the reading (and the following productions). Are we okay?

I moved everything to Model::new() and added some tests. However, there is a weirdness with multiple versions of transit_model, I'll try to see if I can improve it.

@woshilapin
Copy link
Contributor Author

I added some assertions on the logs in c72c257 and moved some tests to a better place in 564aca2 (in the same place where the function sort_and_check_stop_times is implemented).

@woshilapin
Copy link
Contributor Author

I removed the transmute trick because it's really just a trick and not really nice (see 52142e0).

ArnaudOggy
ArnaudOggy previously approved these changes Oct 27, 2021
@woshilapin
Copy link
Contributor Author

I added @prhod as a reviewer for the documentation part.

@woshilapin woshilapin merged commit 81255d8 into master Oct 27, 2021
@woshilapin woshilapin deleted the growing-stop-times branch October 27, 2021 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants