Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Don't export dummy stop time #816

Merged
merged 6 commits into from
Sep 16, 2021
Merged

[feature] Don't export dummy stop time #816

merged 6 commits into from
Sep 16, 2021

Conversation

patochectp
Copy link
Member

@patochectp patochectp commented Sep 14, 2021 •
edited by ArnaudOggy
Loading

Ref. ND-1603

@patochectp patochectp mentioned this pull request Sep 14, 2021
Closed
woshilapin
woshilapin previously approved these changes Sep 14, 2021
View reviewed changes
@ArnaudOggy ArnaudOggy self-requested a review September 15, 2021 08:44
@ArnaudOggy
Copy link
Contributor

ArnaudOggy commented Sep 15, 2021 •
edited
Loading

@patochectp , @woshilapin
We risk having some data inconsistencies, such as vj-headsigns, routes names or others.
These data exist in the input ntfs, and therefore will not be recalculated.
But it can be acceptable i think.

ArnaudOggy
ArnaudOggy previously approved these changes Sep 15, 2021
View reviewed changes
@ArnaudOggy ArnaudOggy self-requested a review September 15, 2021 15:06
@ArnaudOggy
Copy link
Contributor

ArnaudOggy commented Sep 16, 2021 •
edited
Loading

@patochectp , @woshilapin
We risk having some data inconsistencies, such as vj-headsigns, routes names or others.
These data exist in the input ntfs, and therefore will not be recalculated.
But it can be acceptable i think.

Seen with the boss. It's ok.

@patochectp patochectp merged commit d32c06a into master Sep 16, 2021
@patochectp patochectp deleted the dont_export_dummy_stop_time branch September 16, 2021 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woshilapin woshilapin woshilapin approved these changes

@ArnaudOggy ArnaudOggy ArnaudOggy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patochectp @ArnaudOggy @woshilapin