[feature] keep the original order of vehicle journeys #784
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a
HashMap
to filter theVehicleJourney
then iterating again over them makes the final order ofVehicleJourney
completely random compare to the input order. This is not really desirable for two reasons:HashMap
is randomized at runtime: it might actually cause some problems for testingNote that we're talking about
transit_model
library end-users (usingModel
). The binaries will also write the output files in different order but semantically, the model is still the same so it's not incorrect.This modification should barely impact the performance since this is not really changing how the algorithm works.
🔍 Hint - to ease the review, hide whitespace changes