[feature] check stop time growing #768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woshilapin
reviewed
Apr 23, 2021
src/model.rs
Outdated
Comment on lines
2766
to
2771
| let collections = collections(); | ||
| let mut vj = create_vehicle_journey_with( | ||
| "trip:1", | ||
| vec!["stop_point:1", "stop_point:2"], | ||
| &collections, | ||
| ); |
There was a problem hiding this comment.
Instead of these custom functions, you could now use the model_builder to build the model you want.
src/model.rs
Outdated
Comment on lines
2774
to
2776
| let shift = Time::new(sequence as u32, 0, 0); | ||
| stop_time.departure_time = stop_time.departure_time + shift; | ||
| stop_time.arrival_time = stop_time.arrival_time + shift; |
There was a problem hiding this comment.
It took me a minute to understand what was happening here. I usually think it's a good idea to make a test as dumb as possible... because if your test is buggy, then nothing is testing the test!
patochectp
force-pushed
the
check_stop_time_growing
branch
from
d03225e to
5556d33
Compare
ArnaudOggy
reviewed
Apr 23, 2021
patochectp
force-pushed
the
check_stop_time_growing
branch
from
5556d33 to
a21f99e
Compare
ArnaudOggy
previously approved these changes
Apr 23, 2021
woshilapin
previously approved these changes
Apr 26, 2021
patochectp
force-pushed
the
check_stop_time_growing
branch
from
a21f99e to
a3faecf
Compare
woshilapin
approved these changes
Apr 26, 2021
ArnaudOggy
approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: ND-1355