Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tech] Add a precise git_version to transit-model #754
[tech] Add a precise git_version to transit-model #754
Changes from all commits
0847a0b
4ed9834
ffef1eb
5a8bfd4
da3a944
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be able to track more than one deps (and reuse it in binaries using libs that depends on tm), should we already do something like:
The deps-separating
,
could be handled via an option onother_deps_versions
, or just asked-for into thisother_deps_versions
(like this suggestion).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hum don't you think the other dependency will have it's own way of tracking the version? i don't really think it's the right place to put it but maybe we can talk about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, so the plan in binaries-that-depends-on-lib-depending-on-TM is to pass
GIT_VERSION
of the lib-depending-on-TM intobinary_version
(and forget aboutCARGO_PKG_VERSION
of binaries).