[feature] update to 'minidom:0.13.0' #746
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woshilapin
force-pushed
the
minidom-0.13
branch
from
ffec3d1 to
8438550
Compare
woshilapin
commented
Feb 19, 2021
| @@ -120,6 +120,13 @@ fn only_alphanumeric(s: &str) -> String { | |||
| s.chars().filter(|c| c.is_alphanumeric()).collect() | |||
| } | |||
|
|
|||
| fn write_file(filepath: &PathBuf, netex: Element) -> Result<()> { | |||
| let file = File::create(filepath)?; | |||
| let mut writer = minidom::quick_xml::Writer::new_with_indent(file, b'\t', 1); | |||
There was a problem hiding this comment.
I would also like to propose the following modification to avoid indented XML files in release mode.
Suggested change
| let mut writer = minidom::quick_xml::Writer::new_with_indent(file, b'\t', 1); | |
| #[cfg(debug_assertions)] | |
| let mut writer = minidom::quick_xml::Writer::new_with_indent(file, b'\t', 1); | |
| #[cfg(not(debug_assertions))] | |
| let mut writer = minidom::quick_xml::Writer::new(file); |
woshilapin
commented
Feb 19, 2021
Comment on lines
+74
to
+75
| [patch.crates-io] | ||
| minidom_ext = { git = "https://github.com/CanalTP/minidom_ext", branch = "minidom-0.13" } |
There was a problem hiding this comment.
This has to be removed before merging.
|
|
1 task
This was referenced Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on hove-io/minidom_ext#6.
I'm removing entirely the dependence on
minidom_writerand uses the already available APIs fromminidomin order to write XML files. A few modifications to the fixtures had to be done but their only formatting differences, not semantic.I also removed
quick_xmlfromCargo.toml(see hove-io/minidom_ext#6 for the explanation).