[ci] use 'rust-ci:latest-proj' #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoine-de
previously approved these changes
Feb 16, 2021
pbougue
previously approved these changes
Feb 17, 2021
woshilapin
commented
Feb 17, 2021
pbougue
reviewed
Feb 18, 2021
Should be good now, I've fixed it in b27f79f. |
'EPSG:*' creates a dependency on 'proj-data' which is harder to maintain. We're using the website epsg.io to know the exact string to use in replacement.
pbougue
approved these changes
Feb 22, 2021
pbougue
suggested changes
Feb 22, 2021
pbougue
reviewed
Feb 22, 2021
| ENV PATH "/root/.cargo/bin:$PATH" | ||
| # build the project | ||
| RUN cargo build --workspace --release | ||
| RUN mkdir /usr/src/bin && for file in ls ./target/release/*; do if test -f $file -a -x $file; then cp $file /usr/src/bin; fi; done |
There was a problem hiding this comment.
minor
Suggested change
| RUN mkdir /usr/src/bin && for file in ls ./target/release/*; do if test -f $file -a -x $file; then cp $file /usr/src/bin; fi; done | |
| RUN mkdir /usr/src/bin && for file in ls ./target/release/*; do if test -f $file -a -x $file; then cp $file /usr/src/bin; fi; done |
pbougue
reviewed
Feb 22, 2021
pbougue
reviewed
Feb 22, 2021
pbougue
approved these changes
Feb 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use now the custom image that already contains
rustfmt,clippy,cargo-auditandlibproj. This should improve the build time and make it more reliable withlibprojsince we're not depending anymore on the custom.deb.kisiodigital/rust-ci(see https://github.com/CanalTP/ci-images/pull/17)