[feature] read gtfs route as line #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patochectp
force-pushed
the
read_gtfs_as_line
branch
from
177243b to
39dc07c
Compare
antoine-de
reviewed
Dec 22, 2020
antoine-de
previously approved these changes
Dec 23, 2020
antoine-de
previously approved these changes
Dec 23, 2020
datanel
reviewed
Jan 4, 2021
woshilapin
suggested changes
Jan 4, 2021
There was a problem hiding this comment.
A few missing things:
- Please bump the version (minor) of
transit_model - The specification needs to be updated
https://github.com/CanalTP/transit_model/blob/master/documentation/gtfs_to_ntfs_specs.md
src/gtfs/mod.rs
Outdated
| pub read_as_line: bool, | ||
| } | ||
|
|
||
| impl Default for Configuration { |
There was a problem hiding this comment.
I believe you can just derive the Default implementation with
#[derive(Default)]since all you have are the default values (false is the default for bool if I remember correctly).
src/gtfs/read.rs
Outdated
| @@ -3297,4 +3307,103 @@ mod tests { | |||
| ); | |||
| }); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn read_gtfs_routes_as_line() { | |||
There was a problem hiding this comment.
I do not see any generated-UUID in this test. Do we test this?
patochectp
force-pushed
the
read_gtfs_as_line
branch
from
5a2f031 to
f33d555
Compare
Codecov Report
@@ Coverage Diff @@
## master #724 +/- ##
=============================
=============================
Continue to review full report at Codecov.
|
datanel
previously approved these changes
Jan 5, 2021
woshilapin
previously approved these changes
Jan 5, 2021
patochectp
force-pushed
the
read_gtfs_as_line
branch
from
650baea to
d606729
Compare
datanel
approved these changes
Jan 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: ND-1090