Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Rebuild 'trip_headsign' if empty string #717

Merged
merged 1 commit into from
Nov 13, 2020
Merged

[feature] Rebuild 'trip_headsign' if empty string #717

merged 1 commit into from
Nov 13, 2020

Conversation

woshilapin
Copy link
Contributor

Change the parsing of trip_headsign so when the String is empty, it is transformed into None.

ref: ND-1112.

ArnaudOggy
ArnaudOggy previously approved these changes Nov 12, 2020
View reviewed changes
@ArnaudOggy ArnaudOggy dismissed their stale review November 12, 2020 14:38

too early

@ArnaudOggy ArnaudOggy self-requested a review November 12, 2020 14:39
@ArnaudOggy
Copy link
Contributor

Ok for me.
Can you bump in v0.32.2 (or v0.33.0) ?

@woshilapin woshilapin force-pushed the trip_headsign_empty_str branch from da52694 to 48aa553 Compare November 12, 2020 14:46
@woshilapin
Copy link
Contributor Author

Ok for me.
Can you bump in v0.32.2 (or v0.33.0) ?

Done

@woshilapin woshilapin force-pushed the trip_headsign_empty_str branch from 48aa553 to bd3f113 Compare November 12, 2020 14:48
patochectp
patochectp previously approved these changes Nov 12, 2020
View reviewed changes
ArnaudOggy
ArnaudOggy previously approved these changes Nov 12, 2020
View reviewed changes
@woshilapin woshilapin dismissed stale reviews from ArnaudOggy and patochectp via 7f20570 November 12, 2020 16:37
@woshilapin woshilapin force-pushed the trip_headsign_empty_str branch from bd3f113 to 7f20570 Compare November 12, 2020 16:37
@woshilapin woshilapin merged commit 166857b into master Nov 13, 2020
@woshilapin woshilapin deleted the trip_headsign_empty_str branch November 13, 2020 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArnaudOggy ArnaudOggy ArnaudOggy approved these changes

@patochectp patochectp patochectp left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@woshilapin @ArnaudOggy @patochectp