[fix] Do not create transfers when geolocation is (0, 0) #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woshilapin
force-pushed
the
no-dumb-transfers
branch
from
0d43720 to
4d8f8ad
Compare
patochectp
approved these changes
Sep 11, 2020
datanel
approved these changes
Sep 11, 2020
datanel
reviewed
Sep 11, 2020
It's already version 0.31.2 in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a
StopPointgeolocation is(0, 0), generating a transfer doesn't make sense and will create weird and incorrect behaviors. This PR prevent the creation of such transfers.ref: ND-1016.