[feature] Improve test utils for report on files count #701
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically, in our
test_utils
framework, we test the number of files produced vs the number of files in the fixture and compare them. This sometimes leads to something like this kind of error.This is not very helpful. So I changed it to a comparison of the 2 lists which would show something like this (more helpful I believe). Note that I used a
BTreeSet
instead of aVec
so the list is ordered and the diff much more helpful.As a bonus, hidden files are also filtered. This was inconvenient when you're currently editing a file (like
transfers.txt
) because some editors likevim
create a swap file (like.transfers.txt.swp
).