Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Transfers: add the possibility to determine if a transfer could be created #686

Merged
merged 2 commits into from
Aug 6, 2020

Conversation

datanel
Copy link
Member

@datanel datanel commented Aug 6, 2020

By default transfers that do not already exist and where the distance is less than max_distance will be created.

You can now provide a closure that determines if a transfer must be created.
For example, you could create transfers between stop points that belong to 2 different contributors only.

See the test https://github.com/CanalTP/transit_model/pull/686/files#diff-2349738cf674a54d8af122d1ec0bf821R57

Copy link
Contributor

@pbougue pbougue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about my mut questions as it can get tricky...
Anyway this looks great and tests here are nice !
(Didn't review TT yet)

@datanel datanel merged commit 6ac4d27 into hove-io:master Aug 6, 2020
@datanel datanel deleted the tranfers_condition branch August 6, 2020 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants