[feature] Improve route_name generation in GTFS parsing #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woshilapin
commented
Jul 15, 2020
| @@ -1,3 +1,3 @@ | |||
| route_id,route_name,direction_type,line_id,geometry_id,destination_id | |||
| route:2,plop - plop,forward,route:2,,stoparea:1 | |||
| route:3,plop - plop,forward,route:3,,stoparea:1 | |||
| route:2,ma route 1,forward,route:2,,stoparea:1 | |||
There was a problem hiding this comment.
This modification is due to using route_short_name when route_long_name is empty (the previous implementation was leaving it empty, and therefore, the auto-generation rule was triggered).
papailio
approved these changes
Jul 16, 2020
woshilapin
force-pushed
the
gtfs2ntfs-route_name
branch
from
7626146 to
5f3ad9f
Compare
patochectp
approved these changes
Jul 16, 2020
pbougue
approved these changes
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a Route, we want to apply generic
route_namegeneration unless all trips in that route are in the same direction, in this case, we keep the route's name.Bonus: The specification proposes to use
route_short_nameifroute_long_nameis empty but our previous implementation was only usingroute_long_name. This PR fixes it.ref: ND-681