Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Auto-generate route.destination_id if missing #672

Merged
merged 1 commit into from
Jul 10, 2020

Conversation

woshilapin
Copy link
Contributor

Auto-generate route.destination_id always (it was auto-generated only when route.name was empty).

ref: ND-916

Copy link
Contributor

@pbougue pbougue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess testing on a report (and full fixture) is a bit heavy for this, although I'm not the best to judge this yet :-)

@ArnaudOggy ArnaudOggy merged commit 4d1a429 into hove-io:master Jul 10, 2020
@woshilapin woshilapin deleted the auto_destination_id branch July 10, 2020 15:03
@woshilapin
Copy link
Contributor Author

I guess testing on a report (and full fixture) is a bit heavy for this, although I'm not the best to judge this yet :-)

I actually tried to take a look to test the Report. The problem being that struct Report has all the fields private and no getters (only setters). So a test would mean either comparing files or parsing the JSON file which might be a little bit too much. Another solution I'm thinking about as I write would be to have getters only in test mode...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants