Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tech] [doc] Centralize fmt, clippy & test in makefile #671

Merged
merged 4 commits into from
Jul 10, 2020

Conversation

pbougue
Copy link
Contributor

@pbougue pbougue commented Jul 9, 2020

Centralize in makefile and expose in doc and CI

Also:

TODO:

  • bump version > No need, "major" bump in another PR

Ref. ND-947

Pierre-Etienne Bougue added 3 commits July 9, 2020 14:47
Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just, we used makefile instead of Makefile in other repositories so far. Maybe let's try to keep it consistent. Let's keep it as a Makefile, my sample was small and actually, Makefile is far more frequent.

Makefile Outdated
Comment on lines 32 to 33
cargo test --workspace --all-features
cargo test --workspace
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cargo test --workspace --all-features
cargo test --workspace
cargo test --workspace --all-features --all-targets
cargo test --workspace --all-targets

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, this removes doctests.
See rust-lang/cargo#6669 and https://doc.rust-lang.org/cargo/commands/cargo-test.html

So adding this and the corresponding lines to just trigger doctests.

Running doctests and all-targets
(see rust-lang/cargo#6669)
@pbougue pbougue merged commit 2f6b859 into hove-io:master Jul 10, 2020
@pbougue pbougue deleted the centralize_cmd branch July 10, 2020 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants