-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tech] [doc] Centralize fmt, clippy & test in makefile #671
Conversation
Also add comments and cosmetic refactor
Centralize in makefile and expose in doc and CI Ref. ND-947
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just, we used Let's keep it as a makefile
instead of Makefile
in other repositories so far. Maybe let's try to keep it consistent.Makefile
, my sample was small and actually, Makefile
is far more frequent.
Makefile
Outdated
cargo test --workspace --all-features | ||
cargo test --workspace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cargo test --workspace --all-features | |
cargo test --workspace | |
cargo test --workspace --all-features --all-targets | |
cargo test --workspace --all-targets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, this removes doctests.
See rust-lang/cargo#6669 and https://doc.rust-lang.org/cargo/commands/cargo-test.html
So adding this and the corresponding lines to just trigger doctests.
Running doctests and all-targets (see rust-lang/cargo#6669)
Centralize in makefile and expose in doc and CI
Also:
TODO:
Ref. ND-947