[doc] Improve contributing #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 29, 2020 15:51
woshilapin
reviewed
Jun 29, 2020
woshilapin
approved these changes
Jun 29, 2020
woshilapin
approved these changes
Jun 29, 2020
datanel
reviewed
Jun 30, 2020
| # To format the source code in the entire repository | ||
| cargo clippy --workspace | ||
| # Check lints on the source code in the entire repository | ||
| cargo clippy --workspace --all-features --all-targets -- --warn clippy::cargo --allow clippy::multiple_crate_versions --deny warnings |
There was a problem hiding this comment.
why not put this on Makefile? or clippy.toml or .cargo/config if possible
There was a problem hiding this comment.
Yes, it's spotted. To be addressed in a future PR!
woshilapin
approved these changes
Jun 30, 2020
datanel
approved these changes
Jun 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clippyandtestare checkedThis work is debatable.
A future PR should attempt to use cargo (and maybe makefile) to minimize/centralize commands to type.
Ref. ND-930