[tech] Add default direction_type (forward) to route #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woshilapin
reviewed
Jun 26, 2020
src/model.rs
Outdated
Comment on lines
945
to
949
| let mut routes = self.routes.take(); | ||
| for mut route in &mut routes.iter_mut().filter(|r| r.direction_type.is_none()) { | ||
| route.direction_type = Some(String::from("forward")); | ||
| } | ||
| self.routes = CollectionWithId::new(routes).unwrap(); |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Done in a441d06
Thanks 👍
woshilapin
approved these changes
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a route doesn't have a
direction_type(or empty), thedirection_type"forward" is assigned by default.In order to lighten the workload, we will use a new generic method
enhance_route_directions.Later it will disappear by deleting the Option on the
direction_typefield onRoutestructure(which will require an update of the ntfs)
Ref. ND-945