Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] no inline html in markdown #661

Merged
merged 1 commit into from
Jun 26, 2020

Conversation

datanel
Copy link
Member

@datanel datanel commented Jun 25, 2020

@datanel datanel requested a review from pbougue June 25, 2020 15:06
Copy link
Contributor

@pbougue pbougue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's OK to merge that for me (:tada: editorconfig for all).

Although, I vote against the 2-trailing-spaces (but if the majority is in favor, let's go for it!).

My arguments are:
"meaningful invisible characters" are not natural and it's easy to mistakenly remove those.
\s\s\n means newline, but not \n alone or \s\s alone.
<br> works for md on github, gitlab and when using those md through slate (see doc.navitia.io).

To me this surpasses respecting strict md and removing any useless html in it.

Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm neither for <br> nor \s\s\n, I would just remove these 2 options from our Markdown toolbox. But that's just my opinion. I'll let you decide what's best.

@datanel datanel force-pushed the remove_markdown_br branch from 89e0a22 to 0c67568 Compare June 26, 2020 10:12
@datanel datanel force-pushed the remove_markdown_br branch from 0c67568 to d973619 Compare June 26, 2020 10:15
Copy link
Contributor

@pbougue pbougue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .editorconfig was fine for me, removing all trailing even in md files (but maybe one more tool...).
🎉 for \ 😄

@woshilapin woshilapin merged commit d7de9cd into hove-io:master Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants