[feature] Add binary restrict-validity-period in its crate #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbougue
changed the title
ArnaudOggy
reviewed
Jun 17, 2020
This comment has been minimized.
This comment has been minimized.
|
When we agree on merge I will squash commits just before 😉 |
ArnaudOggy
approved these changes
Jun 17, 2020
woshilapin
approved these changes
Jun 17, 2020
* add readme and doc update * move compute_dataset_validity_period tests into validity_period.rs close to the code
pbougue
force-pushed
the
restrict_validity_period_crate
branch
from
fcb5709 to
f20139d
Compare
woshilapin
approved these changes
Jun 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the binary to transit_model.
Move some related tests closer to the code they test.
🔍 review by commit is advised