Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tech] Remove apply-rules #641

Merged
merged 1 commit into from
Jun 16, 2020
Merged

Conversation

woshilapin
Copy link
Contributor

@woshilapin woshilapin commented Jun 1, 2020

Clean up PR for apply_rules once https://github.com/CanalTP/tartare-tools/pull/87 has been merged.

@woshilapin woshilapin marked this pull request as draft June 4, 2020 08:50
@woshilapin woshilapin force-pushed the apply-rules branch 3 times, most recently from 412630e to 8d4761e Compare June 16, 2020 07:17
OldPropertyValueDoesNotMatch,
GeometryNotValid,
NonConvertibleString,
pub(crate) enum TransferReportCategory {
Copy link
Contributor Author

@woshilapin woshilapin Jun 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ I renamed TransitModelReportCategory into TransferReportCategory and remove the prefix Transfer on all the variants of the enum.

@woshilapin woshilapin marked this pull request as ready for review June 16, 2020 12:52
@ArnaudOggy

This comment has been minimized.

@woshilapin
Copy link
Contributor Author

Can you rebase your branch on master please ? pray

Done

@ArnaudOggy ArnaudOggy merged commit b63ef6b into hove-io:master Jun 16, 2020
@woshilapin woshilapin deleted the apply-rules branch June 29, 2020 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants