[feature] Expose Report and ReportType #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woshilapin
commented
Jun 2, 2020
src/report.rs
Outdated
|
|
||
| impl<R: ReportType> Report<R> { | ||
| /// Creates an empty new report. | ||
| pub fn new() -> Self { |
There was a problem hiding this comment.
Why not implementing Default manually instead?
woshilapin
commented
Jun 2, 2020
src/report.rs
Outdated
|
|
||
| /// Each report record will be categorized with a type implementing this | ||
| /// `ReportType` trait. | ||
| pub trait ReportType: Serialize + PartialEq {} |
There was a problem hiding this comment.
Name the trait with a verb instead of a name.
At the very least ReportCategory is better (Type is connoted in Rust).
patochectp
approved these changes
Jun 2, 2020
ArnaudOggy
approved these changes
Jun 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For moving some part of
transit_modellikeapply_rulesout oftransit_model, we need to exposeReportandReportType. However, some variant enums ofReportTypeare really related toapply_rulesitself, not totransit_model. So I changedReportTypeinto a trait/contract/interface instead of anenum. User needs to implement a type that conforms to this contract. I also movedReportandReportTypeinto their own modulereport.See https://github.com/CanalTP/tartare-tools/pull/77 for how this new trait will be used. In the current PR, one implementation of the new trait
ReportTypeisTransitModelReportTypewhich is nothing else than the oldenum ReportType.