[tech] minor refactoring #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woshilapin
approved these changes
May 4, 2020
| @@ -269,7 +269,7 @@ pub struct Configuration<P: AsRef<Path>> { | |||
| pub on_demand_transport_comment: Option<String>, | |||
| } | |||
|
|
|||
| fn read<H>(file_handler: &mut H, configuration: Configuration<impl AsRef<Path>>) -> Result<Model> | |||
| fn read<H, P: AsRef<Path>>(file_handler: &mut H, configuration: Configuration<P>) -> Result<Model> | |||
There was a problem hiding this comment.
I was pretty happy with your proposition of using impl AsRef<Path> actually. The only difference between the 2 propositions being that one is giving a name to the generic (P here). This could be useful if you have to use it somewhere else but in this case, you don't. So I find impl AsRef<Path> simpler because it avoid the complexity of a new variable name. But whichever you choose to keep, I'm fine with it.
ArnaudOggy
approved these changes
May 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.