-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] add odt comment #618
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can already prepare the reception normally
/// OnDemandTransport comment
#[structopt(long)]
odt_comment: Option<String>,
In gtfs2ntfs/src/main.rs
and gtfs2netexfr/src/main.rs
Done |
opt.config_path, opt.prefix, opt.odt, opt.odt_comment,
7974598
to
a466b11
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor comments, apart from that, nice refactorization.
@@ -36,7 +36,7 @@ struct Opt { | |||
|
|||
/// config file | |||
#[structopt(short = "c", long = "config", parse(from_os_str))] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then you should be able to do this now.
#[structopt(short = "c", long = "config", parse(from_os_str))] | |
#[structopt(short, long, parse(from_os_str))] |
pub on_demand_transport_comment: Option<String>, | ||
} | ||
|
||
fn read<H>(file_handler: &mut H, configuration: Configuration<impl AsRef<Path>>) -> Result<Model> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, any specific reason that made you choose
fn read<H>(file_handler: &mut H, configuration: Configuration<impl AsRef<Path>>) -> Result<Model>
over something like
fn read<H, P: AsRef<Path>>(file_handler: &mut H, configuration: Configuration<P>) -> Result<Model>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apparently it's the same with a small difference https://stackoverflow.com/a/47515540
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent link, thank you.
Thanks for your help ! |
No description provided.