[feature] NeTEx IDFM - Use VehicleJourneyStopAssignment for TN vehiclejourneys #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArnaudOggy
force-pushed
the
netex_idfm_vehiclejourneystopassignment
branch
5 times, most recently
from
7740cbd to
33bfa93
Compare
woshilapin
reviewed
Apr 9, 2020
src/netex_idf/offers.rs
Outdated
Comment on lines
483
to
485
| let stop_place_ref_opt: Option<String> = psa_element | ||
| .only_child("StopPlaceRef") | ||
| .and_then(|stop_place_ref_el| stop_place_ref_el.attribute("ref")); |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ArnaudOggy
force-pushed
the
netex_idfm_vehiclejourneystopassignment
branch
from
9c272fd to
c19cefd
Compare
woshilapin
previously approved these changes
Apr 9, 2020
ArnaudOggy
force-pushed
the
netex_idfm_vehiclejourneystopassignment
branch
2 times, most recently
from
5995770 to
8421053
Compare
woshilapin
reviewed
Apr 9, 2020
src/netex_idf/offers.rs
Outdated
| use super::*; | ||
| use pretty_assertions::assert_eq; | ||
|
|
||
| fn stop_points() -> (CollectionWithId<StopPoint>, CollectionWithId<StopPoint>) { |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
src/netex_idf/offers.rs
Outdated
| @@ -432,19 +447,103 @@ where | |||
| .collect() | |||
| } | |||
|
|
|||
| fn parse_passenger_stop_assignment<'a, I>(psa_elements: I) -> HashMap<String, String> | |||
| pub fn get_or_create_stop_point( | |||
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ArnaudOggy
force-pushed
the
netex_idfm_vehiclejourneystopassignment
branch
6 times, most recently
from
f730ad9 to
9eb5dad
Compare
woshilapin
previously approved these changes
Apr 10, 2020
src/netex_idf/offers.rs
Outdated
Comment on lines
2056
to
2057
| expected_hashmap.insert(String::from("sspr"), String::from("sp1")); | ||
| assert_eq!(expected_hashmap, passenger_stop_assignment); |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ArnaudOggy
force-pushed
the
netex_idfm_vehiclejourneystopassignment
branch
from
9eb5dad to
fa40e05
Compare
mergify
bot
dismissed
woshilapin’s stale review
Pull request has been modified.
woshilapin
approved these changes
Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.