[doc] ntfs2gtfs: Update location_type according to the code #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woshilapin
reviewed
Feb 21, 2020
| @@ -82,7 +82,7 @@ stop_name | yes | stops.txt | stop_name | |||
| stop_lat | yes | stops.txt | stop_lat | |||
| stop_lon | yes | stops.txt | stop_lon | |||
| zone_id | no | stops.txt | fare_zone_id | |||
| location_type | no | stops.txt | location_type | |||
| location_type | no | stops.txt | location_type | The value is set to `0` if the input value is `0` or invalid or unspecified, `1` if the input value is `1`, `2` if the input value is `3`, `3` if the input value is `4` and `4` if the input value is `5`. | |||
There was a problem hiding this comment.
What about if the input value is 2?
There was a problem hiding this comment.
Some more information. From the current implementation, this is what is done:
- Remove all
stopof type2 - In all
trip, remove allstop_timewhoseparent_stationwas of type2 - Remove all
tripthat don't containsstop_timeanymore
Apart from the fact that this choice of removing only parts of a trip is weird, is very possible we also end up with route that don't contain any trip anymore.
There was a problem hiding this comment.
@woshilapin you're right about this "need for sanitize", we'll do it soon.
woshilapin
approved these changes
Feb 21, 2020
prhod
approved these changes
Feb 26, 2020
datanel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.